Let's jump straight into it:

Warband 1 (leader):
Denethor, Steward of Gondor
4 Knights of Minas Tirith with Shield
4 Citadel Guards with Longbows
4 Warriors of Minas Tirith with Spear & Shield

Warband 2:
Boromir with Shield (I don't own a Bannermir)
2 Knights of Minas Tirith with Shield
1 Knight of Minas Tirith with Banner
6 Warriors of Minas Tirith with Shield
6 Warriors of Minas Tirith with Spear & Shield

I have not played in a loooooong time (almost 5 years) and therefore am not very experienced with current meta (though there are a lot of Serpent horde players in my group).

My plan is to march up to the enemy, hold them in place with the Warriors, whilst flanking them with the Knights. The Citadel Guard will provide token shooting, and secure any isolated objectives with the help of their bodyguard rule.

So after saying all that I am mainly wondering about the following:
1. do I have too many knights?
2. is the banner worth it?
3. should I drop a couple warriors to upgrade Denethor to some form of captain? (which will also make Boromir the leader)
4. anything else you think that could be done to improve the list?

Thanks in advance for your words of wisdom

_________________
Currently painting: 12 warriors of Minas Tirith, Beregond

I've been pondering on this for a couple of days and I think I'll have a go at it.

1. In part, yes. I don't put a lot of stock in MT knights without Boromir's banner giving them fight 4. Fight 3 cav tends not to be able to carry the charge more often than not in my experience. However, you'll probably find the extra move to be useful at small points levels, so I'd advise dropping only one in favor of get Boromir a horse. And possibly a lance if you have an extra point. It will make him (as the main piece of your army) a lot stronger, but it will also make the knights more of a support to him rather than being the hitting power in their own right. Therefore, making their individual success or failure less important to the overall outcome.

2. Yes, the banner is probably worth it. That reroll is a big help to your heroes and cavalry.

3. No, I think Denethor is worth his points. He is a decent fighter, leads troops for less than a captain, and lets Boromir live dangerously without fear of loosing victory points for a leader taking a lucky wound.

4. Most of my ideas for improvement (beyond getting Boromir a horse) involve playing wider with Hurin or Faramir and a Beregond instead of Boromir. I think that changes the character of the list to drastically though so I'd say not really.

_________________
"Draw your sword with a heavy heart, but swing it with a heavy hand"

Thanks for the reply, I think I'm going to try the list as it is and see how it goes, but long term I will take some of your suggestions on board. (In the future I will probably swap the Knight with Banner and a couple warriors for Bannermir on horse)

_________________
Currently painting: 12 warriors of Minas Tirith, Beregond